Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs #91

Closed
wants to merge 1 commit into from

Conversation

pkumaraswamy
Copy link

@pkumaraswamy pkumaraswamy commented Sep 4, 2024

This is a clean backport.
Internal tests are green and related jck tests are green as well


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8339194 to be approved
  • JDK-8337664 needs maintainer approval

Issues

  • JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs (Enhancement - P3 - Approved)
  • JDK-8339194: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jdk23u.git pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/91.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2024

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3e4583b: 8335397: Improve reliability of TestRecursiveMonitorChurn.java
  • ee1f2f6: 8333522: JFR SwapSpace event might read wrong free swap space size
  • 8cb4462: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 7bdece3: 8337780: RISC-V: C2: Change C calling convention for sp to NS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport bbb516163d400a9c7e923e423fe2a60091b59322 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

⚠️ @pkumaraswamy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Sep 4, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 4, 2024
@pkumaraswamy
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@pkumaraswamy
Your change (at version e168dce) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Sep 4, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

Going to push as commit 7d49c52.
Since your change was applied there have been 5 commits pushed to the master branch:

  • a695694: 8337958: Out-of-bounds array access in secondary_super_cache
  • 3e4583b: 8335397: Improve reliability of TestRecursiveMonitorChurn.java
  • ee1f2f6: 8333522: JFR SwapSpace event might read wrong free swap space size
  • 8cb4462: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 7bdece3: 8337780: RISC-V: C2: Change C calling convention for sp to NS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2024
@openjdk openjdk bot closed this Sep 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@coffeys @pkumaraswamy Pushed as commit 7d49c52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin
Copy link
Member

GoeLin commented Sep 5, 2024

@pkumaraswamy , @coffeys
For some reason the backport is not annotated to the bug. Did you eventually make a closed backport somehow? Could you please open it up?

@coffeys
Copy link
Contributor

coffeys commented Sep 5, 2024

@pkumaraswamy , @coffeys For some reason the backport is not annotated to the bug. Did you eventually make a closed backport somehow? Could you please open it up?

the issue should now be visible. As per JDK crypto roadmap - the aim is for October release:
https://www.java.com/en/jre-jdk-cryptoroadmap.html

@GoeLin
Copy link
Member

GoeLin commented Sep 5, 2024

Thanks for the info and opening the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants