Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds #95

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Sep 9, 2024

Hi all,

This pull request contains a backport of commit a18d9d84 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 9 Sep 2024 and was reviewed by Aggelos Biboudis.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326616 needs maintainer approval

Issue

  • JDK-8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/95/head:pull/95
$ git checkout pull/95

Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.org/jdk23u.git pull/95/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 95

View PR using the GUI difftool:
$ git pr show -t 95

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/95.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4b75cb0: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
  • ef87a06: 8338402: GHA: some of bundles may not get removed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds Sep 9, 2024
@openjdk
Copy link

openjdk bot commented Sep 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix javac bug which cause tests intermittent timeout.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@sendaoYan
8326616: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 9, 2024
@sendaoYan
Copy link
Member Author

GHA report two test failures:

  1. ClhsdbPstack.java#process and ClhsdbSource.java fails on macos-aarch64, which has been recorded by JDK-8247940, I think it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@sendaoYan
Your change (at version 8c58c8a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit a21db48.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
  • 127a68a: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
  • 73313ef: 8334229: Optimize InterpreterOopMap layout
  • a6754f3: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
  • faea17a: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
  • ac8e8da: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate
  • 3e84943: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • 227fc46: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
  • f7d38e1: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent
  • bf45fbd: 8339741: RISC-V: C ABI breakage for integer on stack
  • ... and 3 more: https://git.openjdk.org/jdk23u/compare/325d5c87cd38cc7e8cb7c1b651b779f0263f9f89...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@shipilev @sendaoYan Pushed as commit a21db48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants