Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339741: RISC-V: C ABI breakage for integer on stack #96

Closed

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Sep 13, 2024

Hi all,

This pull request contains a backport of commit bfe7f920 from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry.

Applies clean, sanity tested, risc-v only.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339741 needs maintainer approval

Issue

  • JDK-8339741: RISC-V: C ABI breakage for integer on stack (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/96/head:pull/96
$ git checkout pull/96

Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.org/jdk23u.git pull/96/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 96

View PR using the GUI difftool:
$ git pr show -t 96

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/96.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2024

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339741: RISC-V: C ABI breakage for integer on stack

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport bfe7f9205b56483b4364130a3a87c58c3fc82998 8339741: RISC-V: C ABI breakage for integer on stack Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

⚠️ @robehn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robehn
Copy link
Contributor Author

robehn commented Sep 13, 2024

/approval request C ABI breakage to native functions using more than 8 arguments, if int/short/char. Applies clean and sanity tested, risc-v only.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@robehn usage: /approval [<id>] (request|cancel) [<text>]

@robehn
Copy link
Contributor Author

robehn commented Sep 13, 2024

/approval request C ABI breakage to native functions using more than 8 arguments, if int/short/char. Applies clean and sanity tested, risc-v only.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@robehn
8339741: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 13, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 16, 2024
@robehn
Copy link
Contributor Author

robehn commented Sep 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

Going to push as commit bf45fbd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2024
@openjdk openjdk bot closed this Sep 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@robehn Pushed as commit bf45fbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants