-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339741: RISC-V: C ABI breakage for integer on stack #96
8339741: RISC-V: C ABI breakage for integer on stack #96
Conversation
👋 Welcome back rehn! A progress list of the required criteria for merging this PR into |
@robehn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approval request C ABI breakage to native functions using more than 8 arguments, if int/short/char. Applies clean and sanity tested, risc-v only. |
@robehn usage: |
/approval request C ABI breakage to native functions using more than 8 arguments, if int/short/char. Applies clean and sanity tested, risc-v only. |
/integrate |
Going to push as commit bf45fbd. |
Hi all,
This pull request contains a backport of commit bfe7f920 from the openjdk/jdk repository.
The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry.
Applies clean, sanity tested, risc-v only.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/96/head:pull/96
$ git checkout pull/96
Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.org/jdk23u.git pull/96/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 96
View PR using the GUI difftool:
$ git pr show -t 96
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/96.diff
Webrev
Link to Webrev Comment