8338389: [JFR] Long strings should be added to the string pool

[jaokim]

Backport of fix to pool all longer strings in JFR events.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8338389 needs maintainer approval

Issue

• JDK-8338389: [JFR] Long strings should be added to the string pool (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/97/head:pull/97
$ git checkout pull/97

Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.org/jdk23u.git pull/97/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 97

View PR using the GUI difftool:
$ git pr show -t 97

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/97.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jnordstrom! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaokim This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338389: [JFR] Long strings should be added to the string pool

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 127a68a: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
• 73313ef: 8334229: Optimize InterpreterOopMap layout
• a6754f3: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
• faea17a: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
• ... and 5 more: https://git.openjdk.org/jdk23u/compare/b2162ba41b16f1f82df873d38205c9353d9c1c24...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jaokim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a0745935)

[jaokim]

/approval request Adds long string from JFR events to JFR StringPool, in order to decrease size of recordings. Applies clean and tested.

[openjdk]

@jaokim
8338389: The approval request has been created successfully.

[jaokim]

/integrate

[openjdk]

@jaokim
Your change (at version a074593) is now ready to be sponsored by a Committer.

[mgronlun]

/sponsor

[openjdk]

Going to push as commit 54bb851.
Since your change was applied there have been 15 commits pushed to the master branch:

• 5979904: 8337876: [IR Framework] Add support for IR tests with @stable
• 547a229: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• c212fe6: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
• 7f9c4ab: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• a21db48: 8326616: tools/javac/patterns/Exhaustiveness.java intermittently Timeout signalled after 480 seconds
• 8f53f51: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 127a68a: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
• 73313ef: 8334229: Optimize InterpreterOopMap layout
• a6754f3: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
• faea17a: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
• ... and 5 more: https://git.openjdk.org/jdk23u/compare/b2162ba41b16f1f82df873d38205c9353d9c1c24...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun @jaokim Pushed as commit 54bb851.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.