-
Notifications
You must be signed in to change notification settings - Fork 64
8343191: Cgroup v1 subsystem fails to set subsystem path #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343191: Cgroup v1 subsystem fails to set subsystem path #113
Conversation
👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into |
@sercher This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request The fix improves container detection, applies cleanly to jdk24u. There's no compatibility impact. |
JDK-8351382 fixes the test failure with docker/podman in rootless mode. |
/integrate |
/sponsor |
Going to push as commit 8a4f476.
Your commit was automatically rebased without conflicts. |
@phohensee @sercher Pushed as commit 8a4f476. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit de29ef3b from the openjdk/jdk repository.
The commit being backported was authored by @sercher and was reviewed by @jerboaa and @MBaesken.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/113/head:pull/113
$ git checkout pull/113
Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.org/jdk24u.git pull/113/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 113
View PR using the GUI difftool:
$ git pr show -t 113
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/113.diff
Using Webrev
Link to Webrev Comment