Skip to content

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 6, 2025

Hi all,

This pull request contains a backport of commit 5c552a9d from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 6 Mar 2025 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349358 needs maintainer approval

Issue

  • JDK-8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jdk24u.git pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/115.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 23389d0: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
  • 1603de1: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 33960cf: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5c552a9d64c8116161cb9ef4c777e75a2602a75b 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to remove obsolescent JMH tests which can not run normally, no risk.

@openjdk
Copy link

openjdk bot commented Mar 7, 2025

@sendaoYan
8349358: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 7, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

Going to push as commit c14b3c2.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 959e026: 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024
  • e5e3971: 8350546: Several java/net/InetAddress tests fails UnknownHostException
  • c042f41: 8350202: Tune for Power10 CPUs on Linux ppc64le
  • 1315bbb: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
  • 76ef728: 8351223: Update localized resources in keytool and jarsigner
  • 31a383a: 8280991: [XWayland] No displayChanged event after setDisplayMode call
  • f2ffbbd: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
  • 0ceff4b: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
  • 320ce2f: 8350201: Out of bounds access on Linux aarch64 in os::print_register_info
  • 23389d0: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
  • ... and 2 more: https://git.openjdk.org/jdk24u/compare/6109c0b935f1d6f3a25b6a309dcc9c02f2fec242...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2025
@openjdk openjdk bot closed this Mar 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@sendaoYan Pushed as commit c14b3c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant