Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI #12

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 4, 2025

Hi all,

This pull request contains a backport of commit a0b7c4f0 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 18 Dec 2024 and was reviewed by Alexey Ivanov and Abhishek Kumar.

Thanks!


Progress

  • JDK-8346324 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/jdk24u.git pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/12.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 4, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a0b7c4f015c694425893b8d21d2aecae71a3b604 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI Jan 4, 2025
@openjdk
Copy link

openjdk bot commented Jan 4, 2025

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review January 28, 2025 07:09
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2025

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jan 28, 2025

/approval request for backport. Clean backport. Fix for the testbug. tested on linux, windows, macos.

@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@mrserb
8346324: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 28, 2025
@mrserb
Copy link
Member Author

mrserb commented Jan 29, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

Going to push as commit a54a588.
Since your change was applied there have been 88 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2025
@openjdk openjdk bot closed this Jan 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@mrserb Pushed as commit a54a588.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant