Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jan 8, 2025

Clean backport to improve diff generation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346239 needs maintainer approval

Issue

  • JDK-8346239: Improve memory efficiency of JimageDiffGenerator (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk24u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/13.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346239: Improve memory efficiency of JimageDiffGenerator

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f696d9c521fa13969cb81381dc8586bcdccf67d9 8346239: Improve memory efficiency of JimageDiffGenerator Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 8, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

Going to push as commit 0243349.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ca30621: 8346082: Output JVMTI agent information in hserr files
  • e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2025
@openjdk openjdk bot closed this Jan 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@jerboaa Pushed as commit 0243349.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant