Skip to content

8303770: Remove Baltimore root certificate expiring in May 2025 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Mar 12, 2025

Hi all,

This pull request contains a backport of commit 23716967 from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 12 Mar 2025 and was reviewed by Aleksey Shipilev and Sean Mullan.

Thanks!


Progress

  • JDK-8303770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303770: Remove Baltimore root certificate expiring in May 2025 (Task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/131/head:pull/131
$ git checkout pull/131

Update a local copy of the PR:
$ git checkout pull/131
$ git pull https://git.openjdk.org/jdk24u.git pull/131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 131

View PR using the GUI difftool:
$ git pr show -t 131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/131.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2025

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303770: Remove Baltimore root certificate expiring in May 2025

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
  • 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2371696781edc040d8fa8133c78b284a2e3de1ed 8303770: Remove Baltimore root certificate expiring in May 2025 Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2025

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Mar 12, 2025

/approval 8303770 request The fix is to remove expired root CA certificate. The patch applies cleanly and has good test coverage. This fix is to be included in JDK 24.0.2 release.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@rhalade
8303770: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 12, 2025
@rhalade
Copy link
Member Author

rhalade commented Mar 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

Going to push as commit 186c4f0.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
  • 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2025
@openjdk openjdk bot closed this Mar 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@rhalade Pushed as commit 186c4f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant