8346887: DrawFocusRect() may cause an assertion failure

[satyenme]

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8346887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk24u.git pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/14.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346887: DrawFocusRect() may cause an assertion failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ca30621: 8346082: Output JVMTI agent information in hserr files
• e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (8b5d344b)

[satyenme]

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1, tier2, and GHA tests. Risk is low.

[openjdk]

@satyenme
8346887: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 8b5d344) is now ready to be sponsored by a Committer.

[Rudometov]

/sponsor

[openjdk]

Going to push as commit 33561bf.
Since your change was applied there have been 3 commits pushed to the master branch:

• 0243349: 8346239: Improve memory efficiency of JimageDiffGenerator
• ca30621: 8346082: Output JVMTI agent information in hserr files
• e9109e8: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689

Your commit was automatically rebased without conflicts.

[openjdk]

@Rudometov @satyenme Pushed as commit 33561bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.