Skip to content

8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ksreenath-ora
Copy link
Contributor

@ksreenath-ora ksreenath-ora commented Mar 17, 2025

clean backport


Progress

  • Change must not contain extraneous whitespace
  • JDK-8346049 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/140/head:pull/140
$ git checkout pull/140

Update a local copy of the PR:
$ git checkout pull/140
$ git pull https://git.openjdk.org/jdk24u.git pull/140/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 140

View PR using the GUI difftool:
$ git pr show -t 140

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/140.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back ksreenath-ora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@ksreenath-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
  • 48f11a4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
  • 4b46d73: 8348598: Update Libpng to 1.6.47
  • 7b0a0ba: 8349378: Build splashscreen lib with SIZE optimization
  • 512cdb2: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
  • 7dd8681: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
  • 9880a97: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
  • 9d41ba1: 8348261: assert(n->is_Mem()) failed: memory node required
  • 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
  • 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • ... and 6 more: https://git.openjdk.org/jdk24u/compare/186c4f0682132d37605c0df2977a338ff8d510cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1eb54e4228ba9319ac2f980055ed366dd861ec0b 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

This backport pull request has now been updated with issue from the original commit.

@ksreenath-ora ksreenath-ora marked this pull request as ready for review March 19, 2025 04:35
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

⚠️ @ksreenath-ora the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8352005
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2025

Webrevs

@ksreenath-ora
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@ksreenath-ora
Your change (at version efacf97) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Mar 26, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 26, 2025

Going to push as commit 9aa311f.
Since your change was applied there have been 16 commits pushed to the master branch:

  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
  • 48f11a4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
  • 4b46d73: 8348598: Update Libpng to 1.6.47
  • 7b0a0ba: 8349378: Build splashscreen lib with SIZE optimization
  • 512cdb2: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
  • 7dd8681: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
  • 9880a97: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
  • 9d41ba1: 8348261: assert(n->is_Mem()) failed: memory node required
  • 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
  • 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • ... and 6 more: https://git.openjdk.org/jdk24u/compare/186c4f0682132d37605c0df2977a338ff8d510cc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2025
@openjdk openjdk bot closed this Mar 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@coffeys @ksreenath-ora Pushed as commit 9aa311f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants