Skip to content

8348261: assert(n->is_Mem()) failed: memory node required #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vnkozlov
Copy link

@vnkozlov vnkozlov commented Mar 18, 2025

Hi all,

This pull request contains a backport of commit f6a8db28 from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Kozlov on 7 Mar 2025 and was reviewed by Christian Hagedorn and Emanuel Peter.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8348261 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348261: assert(n->is_Mem()) failed: memory node required (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/143/head:pull/143
$ git checkout pull/143

Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.org/jdk24u.git pull/143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 143

View PR using the GUI difftool:
$ git pr show -t 143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/143.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2025

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348261: assert(n->is_Mem()) failed: memory node required

Reviewed-by: epeter, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 36765ad: 8351500: G1: NUMA migrations cause crashes in region allocation
  • 3296da8: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • f20051f: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
  • 60cf6a1: 8351639: Improve debuggability of test/langtools/jdk/jshell/JdiHangingListenExecutionControlTest.java test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f6a8db289e5366845f9518fce7a98538017e9570 8348261: assert(n->is_Mem()) failed: memory node required Mar 18, 2025
@openjdk
Copy link

openjdk bot commented Mar 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2025

Webrevs

Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@vnkozlov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2025

Going to push as commit 9d41ba1.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
  • 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 36765ad: 8351500: G1: NUMA migrations cause crashes in region allocation
  • 3296da8: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • f20051f: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
  • 60cf6a1: 8351639: Improve debuggability of test/langtools/jdk/jshell/JdiHangingListenExecutionControlTest.java test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2025
@vnkozlov
Copy link
Author

Thank you, Christian and Emanuel, for reviews.

@openjdk openjdk bot closed this Mar 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2025
@openjdk
Copy link

openjdk bot commented Mar 21, 2025

@vnkozlov Pushed as commit 9d41ba1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants