Skip to content

8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ksreenath-ora
Copy link
Contributor

@ksreenath-ora ksreenath-ora commented Mar 19, 2025

Clean backport of https://bugs.openjdk.org/browse/JDK-8349501 to jdk24u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349501 needs maintainer approval

Issue

  • JDK-8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/147/head:pull/147
$ git checkout pull/147

Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/jdk24u.git pull/147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 147

View PR using the GUI difftool:
$ git pr show -t 147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/147.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2025

👋 Welcome back ksreenath-ora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@ksreenath-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
  • 3eba47b: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
  • 8a4953a: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • 13e1932: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
  • d39bc29: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • 4128d17: 8336042: Caller/callee param size mismatch in deoptimization causes crash
  • 4ed3f6e: 8352512: TestVectorZeroCount: counter not reset between iterations
  • 9aa311f: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
  • ... and 10 more: https://git.openjdk.org/jdk24u/compare/3296da86b8e96a4cfb9494982d59cb564a422e3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b737f7fb3004e4e9c95fba95c6fcda70073ae00e 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

This backport pull request has now been updated with issue from the original commit.

@ksreenath-ora ksreenath-ora marked this pull request as ready for review March 26, 2025 05:18
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

⚠️ @ksreenath-ora This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2025

Webrevs

@openjdk openjdk bot added the approval label Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

⚠️ @ksreenath-ora the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8351957
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 1, 2025
@ksreenath-ora
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@ksreenath-ora
Your change (at version a4f6d56) is now ready to be sponsored by a Committer.

@raviniitw2012
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

Going to push as commit 322da3f.
Since your change was applied there have been 20 commits pushed to the master branch:

  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
  • 3eba47b: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
  • 8a4953a: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • 13e1932: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
  • d39bc29: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • 4128d17: 8336042: Caller/callee param size mismatch in deoptimization causes crash
  • 4ed3f6e: 8352512: TestVectorZeroCount: counter not reset between iterations
  • 9aa311f: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm
  • ... and 10 more: https://git.openjdk.org/jdk24u/compare/3296da86b8e96a4cfb9494982d59cb564a422e3b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2025
@openjdk openjdk bot closed this Apr 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@raviniitw2012 @ksreenath-ora Pushed as commit 322da3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants