8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

[dchuyko]

This is a clean backport of a tiny ForkJoinPool change that corrects the TC subfield masking.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8351933 needs maintainer approval

Issue

• JDK-8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.org/jdk24u.git pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/148.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 9d41ba1: 8348261: assert(n->is_Mem()) failed: memory node required
• 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
• 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @dchuyko This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (07d8df89)

[dchuyko]

/approval request This a tiny bugfix in ForkJoinPool. At one of code paths the TC subfield of ctl field is decremented and the result is not masked correctly, so the RC subfield is not preserved. In older releases that sometimes leads to a stopped pool, but in 24u it's still a bug. The fix from 25 is applied cleanly.

[openjdk]

@dchuyko
8351933: The approval request has been created successfully.

[dchuyko]

/integrate

[openjdk]

@dchuyko
Your change (at version 07d8df8) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 48f11a4.
Since your change was applied there have been 8 commits pushed to the master branch:

• 4b46d73: 8348598: Update Libpng to 1.6.47
• 7b0a0ba: 8349378: Build splashscreen lib with SIZE optimization
• 512cdb2: 8350683: Non-C2 / minimal JVM crashes in the build on ppc64 platforms
• 7dd8681: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
• 9880a97: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• 9d41ba1: 8348261: assert(n->is_Mem()) failed: memory node required
• 77d8da6: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
• 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @dchuyko Pushed as commit 48f11a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.