8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

[kieran-farrell]

@coffeys

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347995 needs maintainer approval

Issue

• JDK-8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk24u.git pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/152.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kieran-farrell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• 36765ad: 8351500: G1: NUMA migrations cause crashes in region allocation
• 3296da8: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
• f20051f: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
• 60cf6a1: 8351639: Improve debuggability of test/langtools/jdk/jshell/JdiHangingListenExecutionControlTest.java test
• 080f997: 8348597: Update HarfBuzz to 10.4.0
• 7a47dcb: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• 186c4f0: 8303770: Remove Baltimore root certificate expiring in May 2025
• 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
• 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path
• ... and 25 more: https://git.openjdk.org/jdk24u/compare/d8d055ed0dcfa270ab091ea9e9856eb57d105b6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (ee223c85)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[kieran-farrell]

/integrate

[openjdk]

@kieran-farrell
Your change (at version ee223c8) is now ready to be sponsored by a Committer.

[coffeys]

/sponsor

[openjdk]

Going to push as commit 77d8da6.
Since your change was applied there have been 35 commits pushed to the master branch:

• 96da000: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• 36765ad: 8351500: G1: NUMA migrations cause crashes in region allocation
• 3296da8: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
• f20051f: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
• 60cf6a1: 8351639: Improve debuggability of test/langtools/jdk/jshell/JdiHangingListenExecutionControlTest.java test
• 080f997: 8348597: Update HarfBuzz to 10.4.0
• 7a47dcb: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• 186c4f0: 8303770: Remove Baltimore root certificate expiring in May 2025
• 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
• 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path
• ... and 25 more: https://git.openjdk.org/jdk24u/compare/d8d055ed0dcfa270ab091ea9e9856eb57d105b6c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coffeys @kieran-farrell Pushed as commit 77d8da6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.