Skip to content

8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

HamzaBenyazid
Copy link
Contributor

@HamzaBenyazid HamzaBenyazid commented Mar 26, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8217914 needs maintainer approval

Issue

  • JDK-8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/159/head:pull/159
$ git checkout pull/159

Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.org/jdk24u.git pull/159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 159

View PR using the GUI difftool:
$ git pr show -t 159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/159.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 26, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2025

Hi @HamzaBenyazid, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user HamzaBenyazid" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@HamzaBenyazid This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e7a1c8660af50a321bc466be2b30412a5b5c4e3c 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

This backport pull request has now been updated with issue from the original commit.

@HamzaBenyazid
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Mar 26, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

⚠️ @HamzaBenyazid This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2025

Webrevs

@HamzaBenyazid
Copy link
Contributor Author

/approval JDK-8217914 request "java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST"

@openjdk
Copy link

openjdk bot commented Apr 9, 2025

@HamzaBenyazid
JDK-8217914: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 9, 2025
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

⚠️ @HamzaBenyazid the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8217914
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 10, 2025
@HamzaBenyazid
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

@HamzaBenyazid
Your change (at version f320e7a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

Going to push as commit 2b7f593.
Since your change was applied there have been 58 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 21, 2025
@openjdk openjdk bot closed this Apr 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

@phohensee @HamzaBenyazid Pushed as commit 2b7f593.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants