Skip to content

8352716: (tz) Update Timezone Data to 2025b #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Mar 27, 2025

Update to tzdata to bring in the latest version, 2025b. The 25u patch applies as is, but needs to be supplemented with the change to zone.tab from 2025b. zone.tab was removed from 25 in JDK-8166983 but still needs to be updated in 24u unless #150 is integrated.

Tests pass:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/java/text/Format                     130   130     0     0   
   jtreg:test/jdk/java/util/TimeZone                    22    22     0     0   
   jtreg:test/jdk/sun/util/calendar                      5     5     0     0   
   jtreg:test/jdk/sun/util/resources                    22    22     0     0   
   jtreg:test/jdk/java/time                            187   187     0     0   
==============================
TEST SUCCESS

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352716 needs maintainer approval

Issue

  • JDK-8352716: (tz) Update Timezone Data to 2025b (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/161/head:pull/161
$ git checkout pull/161

Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jdk24u.git pull/161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 161

View PR using the GUI difftool:
$ git pr show -t 161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/161.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2025

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352716: (tz) Update Timezone Data to 2025b

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 322da3f: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
  • 3eba47b: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
  • 8a4953a: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • 13e1932: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target
  • d39bc29: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1d205f5f0704f251eb68165f3caf1e70d542ae63 8352716: (tz) Update Timezone Data to 2025b Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 27, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

/approval request Regular update of tzdata from the new upstream release. Patch from 25 applies as is but needs to be supplemented with a zone.tab update due to the absence of JDK-8166983 in 24u. java/text/Format, java/util/timezone, sun/util/calendar, sun/util/resources & java/time tests all pass.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

@gnu-andrew
8352716: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 2, 2025
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

Going to push as commit a793cd0.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 931aaaa: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
  • 04dbfe9: 8351277: Remove pipewire from AIX build
  • a49d1a0: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table
  • 2db3100: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
  • f06759c: 8351665: Remove unused UseNUMA in os_aix.cpp
  • 322da3f: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
  • 3eba47b: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
  • 8a4953a: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • ... and 2 more: https://git.openjdk.org/jdk24u/compare/4128d17ec8de8e438ec731bd9791e66411b1b01b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2025
@openjdk openjdk bot closed this Apr 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@gnu-andrew Pushed as commit a793cd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants