Skip to content

8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 1, 2025

Hi all,

This pull request contains a backport of commit ad48846e from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 1 Apr 2025 and was reviewed by Thomas Schatzl.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350386 needs maintainer approval

Issue

  • JDK-8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/jdk24u.git pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/168.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 322da3f: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ad48846edd894073d89839a2771271553b4e27cd 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Apr 2, 2025

/approval request Clean backport to fix test bugs which cause test run fails with JVM option -XX:-UseCodeCacheFlushing. Test-fix only, change has been verified locally, no risk.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

@sendaoYan
8350386: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 2, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

Going to push as commit c15293d.
Since your change was applied there have been 10 commits pushed to the master branch:

  • dc5669a: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized
  • a793cd0: 8352716: (tz) Update Timezone Data to 2025b
  • 931aaaa: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
  • 04dbfe9: 8351277: Remove pipewire from AIX build
  • a49d1a0: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table
  • 2db3100: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
  • f06759c: 8351665: Remove unused UseNUMA in os_aix.cpp
  • 322da3f: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
  • c83786b: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 90124fe: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2025
@openjdk openjdk bot closed this Apr 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@sendaoYan Pushed as commit c15293d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant