Skip to content

8353053: (fs) Add support for UserDefinedFileAttributeView on AIX #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

varada1110
Copy link

@varada1110 varada1110 commented Apr 4, 2025

Hi all,

This pull request contains a backport of commit 1161b566 from the openjdk/jdk repository.

The commit being backported was authored by Varada M on 4 Apr 2025 and was reviewed by Martin Doerr and Joachim Kern.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353053 needs maintainer approval

Issue

  • JDK-8353053: (fs) Add support for UserDefinedFileAttributeView on AIX (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/180/head:pull/180
$ git checkout pull/180

Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.org/jdk24u.git pull/180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 180

View PR using the GUI difftool:
$ git pr show -t 180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/180.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353053: (fs) Add support for UserDefinedFileAttributeView on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c15293d: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
  • dc5669a: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized
  • a793cd0: 8352716: (tz) Update Timezone Data to 2025b

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1161b566ca06786996cf47a4475bcdabaa24cde8 8353053: (fs) Add support for UserDefinedFileAttributeView on AIX Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

⚠️ @varada1110 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@varada1110
Copy link
Author

/approval 8353053 request added support for UserDefinedFileAttributeView on AIX. Build and jtreg testing(java/nio/file) successful.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@varada1110
8353053: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 8, 2025
@varada1110
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@varada1110
Your change (at version 5ba3fc5) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

Going to push as commit 93636bf.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c15293d: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
  • dc5669a: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized
  • a793cd0: 8352716: (tz) Update Timezone Data to 2025b

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2025
@openjdk openjdk bot closed this Apr 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 8, 2025
@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@offamitkumar @varada1110 Pushed as commit 93636bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants