Skip to content

8350211: CTW: Attempt to preload all classes in constant pool #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shyamkishororacle
Copy link
Contributor

@shyamkishororacle shyamkishororacle commented Apr 15, 2025

8350211: CTW: Attempt to preload all classes in constant pool


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350211 needs maintainer approval

Issue

  • JDK-8350211: CTW: Attempt to preload all classes in constant pool (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/194/head:pull/194
$ git checkout pull/194

Update a local copy of the PR:
$ git checkout pull/194
$ git pull https://git.openjdk.org/jdk24u.git pull/194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 194

View PR using the GUI difftool:
$ git pr show -t 194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/194.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2025

👋 Welcome back shyamkishororacle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@shyamkishororacle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350211: CTW: Attempt to preload all classes in constant pool

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d13fd5738f8a3d4b4009c2e15cfd967332d97bbd 8350211: CTW: Attempt to preload all classes in constant pool Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 15, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

⚠️ @shyamkishororacle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shyamkishororacle
Copy link
Contributor Author

/approval 8350211 request Clean backport. CTW: Attempt to preload all classes in constant pool

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@shyamkishororacle
8350211: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@shyamkishororacle This pull request has not yet been marked as ready for integration.

@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@shyamkishororacle This pull request has not yet been marked as ready for integration.

@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@shyamkishororacle This pull request has not yet been marked as ready for integration.

@shyamkishororacle
Copy link
Contributor Author

/approval 8350211 request Clean backport. CTW: Attempt to preload all classes in constant pool

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@shyamkishororacle
8350211: The approval request was already up to date.

@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@shyamkishororacle This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

⚠️ @shyamkishororacle the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backports-8350211
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 17, 2025
@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@shyamkishororacle
Your change (at version 6fd6abd) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Apr 17, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Apr 17, 2025
@phohensee
Copy link
Member

@shyamkishororacle, your "/integrate" appears to have got lost.

@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@shyamkishororacle
Your change (at version 541aa65) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

Going to push as commit 1329551.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2025
@openjdk openjdk bot closed this Apr 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@phohensee @shyamkishororacle Pushed as commit 1329551.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants