Skip to content

8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Apr 16, 2025

Straight Backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349348 needs maintainer approval

Issue

  • JDK-8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jdk24u.git pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/200.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2c314dc: 8353185: Introduce the concept of upgradeable files in context of JEP 493

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 32d6d031514be9cfee5b0fd778cb738b7ff9d770 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2025
@Shivangi-aa
Copy link
Author

Shivangi-aa commented Apr 16, 2025

/approval JDK-8349348 request Refactoring of tests, good to backport to lower releases.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@Shivangi-aa
JDK-8349348: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Apr 16, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 17, 2025
@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@Shivangi-aa
Your change (at version 4919550) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Apr 17, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

Going to push as commit b014cb5.
Since your change was applied there have been 3 commits pushed to the master branch:

  • b6218f8: 8347298: Bug in JPackageCommand.ignoreFakeRuntime()
  • 09d777a: 8353787: Increased number of SHA-384-Digest java.util.jar.Attributes$Name instances leading to higher memory footprint
  • 2c314dc: 8353185: Introduce the concept of upgradeable files in context of JEP 493

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025
@openjdk openjdk bot closed this Apr 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@coffeys @Shivangi-aa Pushed as commit b014cb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants