Skip to content

8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kboulanou
Copy link
Contributor

@kboulanou kboulanou commented Apr 17, 2025

Backport of JDK-8352109

JTREG

runner starting test: java/awt/Desktop/MailTest.java
runner finished test: java/awt/Desktop/MailTest.java
Passed. Execution successful
Test results: passed: 1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352109 needs maintainer approval

Issue

  • JDK-8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/201/head:pull/201
$ git checkout pull/201

Update a local copy of the PR:
$ git checkout pull/201
$ git pull https://git.openjdk.org/jdk24u.git pull/201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 201

View PR using the GUI difftool:
$ git pr show -t 201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/201.diff

Using Webrev

Link to Webrev Comment

@kboulanou
Copy link
Contributor Author

/cover

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

Hi @kboulanou, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kboulanou" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@kboulanou
Copy link
Contributor Author

/approve JDK-8352109 request java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@kboulanou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title backport c7f333888be052aa37fe878bfc2785fc47fbeaaa 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@kboulanou Unknown command cover - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@kboulanou Only integrators for this repository are allowed to issue the /approve command.

@kboulanou
Copy link
Contributor Author

/approval JDK-8352109 request java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@kboulanou
JDK-8352109: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 17, 2025
@kboulanou
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Apr 17, 2025
@kboulanou kboulanou marked this pull request as ready for review April 18, 2025 07:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 18, 2025
@kboulanou
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@kboulanou
Your change (at version cbe45b9) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 18, 2025

Going to push as commit 3d1f63d.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2025
@openjdk openjdk bot closed this Apr 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 18, 2025
@openjdk
Copy link

openjdk bot commented Apr 18, 2025

@phohensee @kboulanou Pushed as commit 3d1f63d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants