8347334: JimageDiffGenerator code clean-ups

[jerboaa]

Clean backport of some code clean-up for JDK-8346239 which got recently backported to 24.0.1 as well.

Adds a test and improves code quality.

---

Progress

• JDK-8347334 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347334: JimageDiffGenerator code clean-ups (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.org/jdk24u.git pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/21.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347334: JimageDiffGenerator code clean-ups

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• c2087ed: 8347124: Clean tests with --enable-linkable-runtime

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (56c4ba87)

[jerboaa]

/integrate

[openjdk]

Going to push as commit 44000a9.
Since your change was applied there have been 5 commits pushed to the master branch:

• 8e0d48c: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac
• 41ea8e0: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
• 934aacc: 8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level
• 4211697: 8347424: Fix and rewrite sun/security/x509/DNSName/LeadingPeriod.java test
• c2087ed: 8347124: Clean tests with --enable-linkable-runtime

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 44000a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.