Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@Domest0s
Copy link

@Domest0s Domest0s commented Apr 29, 2025

Backporting a stabilization fix as the issue was seen in older JDK releases.

Except for test/jdk/ProblemList.txt file, the changes applied cleanly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344671 needs maintainer approval

Issue

  • JDK-8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/212/head:pull/212
$ git checkout pull/212

Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/jdk24u.git pull/212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 212

View PR using the GUI difftool:
$ git pr show -t 212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/212.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2025

👋 Welcome back Domest0s! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the approval label Apr 29, 2025
@Domest0s Domest0s marked this pull request as ready for review May 1, 2025 08:58
@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2025
@Domest0s Domest0s changed the title 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 Backport d979bd859215a16e6398ae627acfd40e8d71102c May 1, 2025
@mlbridge
Copy link

mlbridge bot commented May 1, 2025

Webrevs

@openjdk openjdk bot changed the title Backport d979bd859215a16e6398ae627acfd40e8d71102c 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 May 1, 2025
@openjdk
Copy link

openjdk bot commented May 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 1, 2025
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the test successfully?

@Domest0s
Copy link
Author

Domest0s commented May 2, 2025

Did you run the test successfully?

@phohensee Yes, the 3 tests that used to be problemlisted in mainline and un-problemlisted in the original fix:

  • jdk/jfr/api/consumer/streaming/TestJVMCrash.java
  • jdk/jfr/api/consumer/streaming/TestJVMExit.java
  • jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java

has succeeded on Apple M1 MacOS v15.3.1.
I used our corporate testing infrastructure for that.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lgtm.

@Domest0s
Copy link
Author

Domest0s commented May 6, 2025

@phohensee , thank you for the review.

JDK-8344671 still needs maintainer approval.

@phohensee
Copy link
Member

Just noticed that you don't have GHA testing enabled on this repo. To do that, go to the repo page (e.g., one of mine is https://github.com/phohensee/jdk21u-dev), select Actions, and enable workflows. Also, ask for maintainer approval using the PR comment "/approval request ".

@Domest0s
Copy link
Author

Domest0s commented May 8, 2025

@phohensee Thanks! I've just enabled workflow.

@Domest0s
Copy link
Author

Domest0s commented May 8, 2025

/approval request

@openjdk
Copy link

openjdk bot commented May 8, 2025

@Domest0s
8344671: The approval request has been created successfully.

@Domest0s
Copy link
Author

We are past RDP2 for 24.0.2.

This doesn't seem to be a critical fix. Closing MR.

@Domest0s Domest0s closed this May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approval backport rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants