-
Notifications
You must be signed in to change notification settings - Fork 64
8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 #212
8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 #212
Conversation
|
👋 Welcome back Domest0s! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the test successfully?
@phohensee Yes, the 3 tests that used to be problemlisted in mainline and un-problemlisted in the original fix:
has succeeded on Apple M1 MacOS v15.3.1. |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Lgtm.
|
@phohensee , thank you for the review. JDK-8344671 still needs maintainer approval. |
|
Just noticed that you don't have GHA testing enabled on this repo. To do that, go to the repo page (e.g., one of mine is https://github.com/phohensee/jdk21u-dev), select Actions, and enable workflows. Also, ask for maintainer approval using the PR comment "/approval request ". |
|
@phohensee Thanks! I've just enabled workflow. |
|
/approval request |
|
We are past RDP2 for 24.0.2. This doesn't seem to be a critical fix. Closing MR. |
Backporting a stabilization fix as the issue was seen in older JDK releases.
Except for
test/jdk/ProblemList.txtfile, the changes applied cleanly.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/212/head:pull/212$ git checkout pull/212Update a local copy of the PR:
$ git checkout pull/212$ git pull https://git.openjdk.org/jdk24u.git pull/212/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 212View PR using the GUI difftool:
$ git pr show -t 212Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/212.diff
Using Webrev
Link to Webrev Comment