Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac #22

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jan 16, 2025

Clean backport of a test-only change required for clean tests in some environments. Follow-up to https://bugs.openjdk.org/browse/JDK-8347124 which got backported to 24.0.1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347496 needs maintainer approval

Issue

  • JDK-8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk24u.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/22.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3967696386ecc706927f05dfae0841b3f23e319d 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 16, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 22, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 22, 2025

Going to push as commit 8e0d48c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 41ea8e0: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
  • 934aacc: 8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level
  • 4211697: 8347424: Fix and rewrite sun/security/x509/DNSName/LeadingPeriod.java test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 22, 2025
@openjdk openjdk bot closed this Jan 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 22, 2025
@openjdk
Copy link

openjdk bot commented Jan 22, 2025

@jerboaa Pushed as commit 8e0d48c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant