Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jan 21, 2025

Clean backport of a simple container detection fix which prevents it from working correctly on some distributions like Fedora 41.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347129 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8347129: cpuset cgroups controller is required for no good reason

Issue

  • JDK-8347129: cpuset cgroups controller is required for no good reason (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk24u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/24.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347129: cpuset cgroups controller is required for no good reason

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2de71d04454b04ee887f7bd3e5decbfaa9ab8460 8347129: cpuset cgroups controller is required for no good reason Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 21, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 27, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

Going to push as commit b00bb04.
Since your change was applied there have been 71 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2025
@openjdk openjdk bot closed this Jan 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 27, 2025

@jerboaa Pushed as commit b00bb04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant