8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis

[TheRealMDoerr]

Clean backport of JDK-8348562. It only adds a null check + bailout where the current implementation crashes with SIGSEGV.

---

Progress

• JDK-8348562 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.org/jdk24u.git pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/35.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 5033376: Merge
• 47c15b5: 8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict
• 5f5ed96: 8348890: Fix docs for -XX:AOT* options in java man page
• df57c97: 8348515: Add docs for -XX:AOT* options in java man pages
• 2a1a416: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
• 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
• 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
• 926455d: 8345405: Add JMH showing the regression in 8341649
• ec00b6b: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33
• ... and 15 more: https://git.openjdk.org/jdk24u/compare/96bd21d38391467bfb9f2f83a4ccf326fc61d9b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (5bcf941d)

[TheRealMDoerr]

/approval request The JVM crashes with SIGSEGV without this fix. The fix is very simple and applies cleanly. It only adds a null check and bails out if null. The current implementation crashes in this case.

[openjdk]

@TheRealMDoerr
8348562: The approval request has been created successfully.

[TheRealMDoerr]

Closing in favor of openjdk/jdk#23422.