Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.
/ jdk24u Public archive

8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out#42

Closed
pawanchawdhary1 wants to merge 1 commit intoopenjdk:masterfrom
pawanchawdhary1:8344453
Closed

8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out#42
pawanchawdhary1 wants to merge 1 commit intoopenjdk:masterfrom
pawanchawdhary1:8344453

Conversation

@pawanchawdhary1
Copy link

@pawanchawdhary1 pawanchawdhary1 commented Feb 3, 2025

8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out


Progress

  • JDK-8344453 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/jdk24u.git pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/42.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back pawanchawdhary1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@pawanchawdhary1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • e3d6b0a: 8348600: Update PipeWire to 1.3.81
  • 2397bea: 8322983: Virtual Threads: exclude 2 tests
  • cb5f489: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
  • 754e5dd: 8349058: 'internal proprietary API' warnings make javac warnings unusable
  • 010833d: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • ff59e5b: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
  • ded2ed2: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup
  • 2280d5b: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo()
  • 63a800d: 8345590: AIX 'make all' fails after JDK-8339480
  • 82ccb07: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64
  • ... and 34 more: https://git.openjdk.org/jdk24u/compare/81252ef76899ad95197550a11c2786ccf3cf0cd2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6b022bb64b2109c8cd40ebd3b8b3226cf894544d 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

⚠️ @pawanchawdhary1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 3, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2025

Webrevs

@rsunderbabu
Copy link
Member

/approval 8344453 request Clean backport. Making the test vm flagless as it doesn't reliably trigger JFR events.

@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@rsunderbabu Only the author (@pawanchawdhary1) is allowed to issue the /approval command.

@openjdk openjdk bot added the approval label Feb 8, 2025
@pawanchawdhary1
Copy link
Author

/approval 8344453 request Clean backport. Making the test vm flagless as it doesn't reliably trigger JFR events.

@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@pawanchawdhary1
8344453: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Feb 10, 2025

⚠️ @pawanchawdhary1 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8344453
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 10, 2025
@pawanchawdhary1
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 17, 2025
@openjdk
Copy link

openjdk bot commented Feb 17, 2025

@pawanchawdhary1
Your change (at version b7dbd91) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Feb 24, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 24, 2025

Going to push as commit 924e7bb.
Since your change was applied there have been 59 commits pushed to the master branch:

  • 05d5371: 8349039: Adjust exception No type named in database
  • a5f39c1: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
  • e06d01d: 8349787: java/lang/Thread/virtual/ThreadPollOnYield.java#default passes unexpectedly without libVThreadPinner.so
  • ec34f8b: Merge
  • 6705a92: 8345276: Remove EA from the JDK 24 version string with first RC promotion
  • 681c6d4: 8349084: Update vectors used in several PQC benchmarks
  • f0837b2: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null
  • b1659e3: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis
  • 352a7a9: 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents
  • ba481f0: 8344925: translet-name ignored when package-name is also set
  • ... and 49 more: https://git.openjdk.org/jdk24u/compare/81252ef76899ad95197550a11c2786ccf3cf0cd2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2025
@openjdk openjdk bot closed this Feb 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 24, 2025
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@coffeys @pawanchawdhary1 Pushed as commit 924e7bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants