Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Feb 3, 2025

Straight Backport. Test passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339356 needs maintainer approval

Issue

  • JDK-8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk24u.git pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/43.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 5033376: Merge
  • 47c15b5: 8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict
  • 5f5ed96: 8348890: Fix docs for -XX:AOT* options in java man page
  • df57c97: 8348515: Add docs for -XX:AOT* options in java man pages
  • 2a1a416: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
  • 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
  • b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
  • 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
  • 926455d: 8345405: Add JMH showing the regression in 8341649
  • ec00b6b: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33
  • ... and 3 more: https://git.openjdk.org/jdk24u/compare/81252ef76899ad95197550a11c2786ccf3cf0cd2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f6e7713bb653811423eeb2515c2f69b437750326 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Feb 3, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 3, 2025
@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@Shivangi-aa
Your change (at version 6a9df61) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Feb 4, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 4, 2025

Going to push as commit a681dbb.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 5033376: Merge
  • 47c15b5: 8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict
  • 5f5ed96: 8348890: Fix docs for -XX:AOT* options in java man page
  • df57c97: 8348515: Add docs for -XX:AOT* options in java man pages
  • 2a1a416: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
  • 89c46f1: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
  • b1b55f7: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
  • 15f90f0: 8349017: Update ML tests to verify against ACVP 1.1.0.38 version
  • 926455d: 8345405: Add JMH showing the regression in 8341649
  • ec00b6b: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33
  • ... and 3 more: https://git.openjdk.org/jdk24u/compare/81252ef76899ad95197550a11c2786ccf3cf0cd2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2025
@openjdk openjdk bot closed this Feb 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@coffeys @Shivangi-aa Pushed as commit a681dbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants