-
Notifications
You must be signed in to change notification settings - Fork 63
8344316: security/auth/callback/TextCallbackHandler/Password.java make runnable with JTReg and add the UI #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval JDK-8344316 request Good to Backport. Needed in lower releases too. Test passed |
@Shivangi-aa |
/integrate |
@Shivangi-aa |
/sponsor |
@coffeys @Shivangi-aa Pushed as commit 0397f98. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Straight Backport. Needed in lower releases too. Test passed
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/64/head:pull/64
$ git checkout pull/64
Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.org/jdk24u.git pull/64/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 64
View PR using the GUI difftool:
$ git pr show -t 64
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/64.diff
Using Webrev
Link to Webrev Comment