8349058: 'internal proprietary API' warnings make javac warnings unusable

[cushon]

Hi,

This pull request contains a backport of commit 1ab1c1d53b86228be85aac96fa5d69db39ac6317 from the openjdk/jdk repository to fix JDK-8349058.

It's a clean backport that partially backs out an earlier change, the affected test passes.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8349058 needs maintainer approval

Issue

• JDK-8349058: 'internal proprietary API' warnings make javac warnings unusable (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/69/head:pull/69
$ git checkout pull/69

Update a local copy of the PR:
$ git checkout pull/69
$ git pull https://git.openjdk.org/jdk24u.git pull/69/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 69

View PR using the GUI difftool:
$ git pr show -t 69

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/69.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349058: 'internal proprietary API' warnings make javac warnings unusable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (f333075d)

[cushon]

/approval request backporting this patch fix fixes a usability issue with 'sunapi' diagnostics. Low risk as the backport is backing out the changes made in JDK-8332744 and restoring the long-standing earlier behaviour. The patch applied cleanly, the affected tests pass.

[openjdk]

@cushon
8349058: The approval request has been created successfully.

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version f333075) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 754e5dd.
Since your change was applied there have been 4 commits pushed to the master branch:

• 010833d: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
• ff59e5b: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
• ded2ed2: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup
• 2280d5b: 8347018: C2: Insertion of Assertion Predicates ignores the effects of PhaseIdealLoop::clone_up_backedge_goo()

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @cushon Pushed as commit 754e5dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.