-
Notifications
You must be signed in to change notification settings - Fork 63
8344925: translet-name ignored when package-name is also set #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344925: translet-name ignored when package-name is also set #73
Conversation
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
@galderz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval |
@galderz usage: |
/approval request The bug impacts Red Hat middleware engineers trying to adopt JDK's xalan API |
/integrate |
/sponsor |
Going to push as commit ba481f0.
Your commit was automatically rebased without conflicts. |
Passed tier1 and tier2 tests on x64.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/73/head:pull/73
$ git checkout pull/73
Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk24u.git pull/73/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 73
View PR using the GUI difftool:
$ git pr show -t 73
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/73.diff
Using Webrev
Link to Webrev Comment