Skip to content

8344925: translet-name ignored when package-name is also set #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

galderz
Copy link
Contributor

@galderz galderz commented Feb 13, 2025

Passed tier1 and tier2 tests on x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344925 needs maintainer approval

Issue

  • JDK-8344925: translet-name ignored when package-name is also set (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk24u.git pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/73.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2025

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@galderz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344925: translet-name ignored when package-name is also set

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • a6de59e: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland
  • e8808b7: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
  • d06d7a4: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
  • d8feb0f: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges
  • e3d6b0a: 8348600: Update PipeWire to 1.3.81
  • 2397bea: 8322983: Virtual Threads: exclude 2 tests
  • cb5f489: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
  • 754e5dd: 8349058: 'internal proprietary API' warnings make javac warnings unusable
  • 010833d: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • ff59e5b: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
  • ... and 2 more: https://git.openjdk.org/jdk24u/compare/63a800da86a986010fe8a4777781a1b56a46200b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2025

Webrevs

@galderz galderz changed the title 8344925: translet-name ignored when package-name is also set Backport 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 Feb 13, 2025
@openjdk openjdk bot changed the title Backport 3989a199578fc1d91988cfdbb95f11dd6d4c7b81 8344925: translet-name ignored when package-name is also set Feb 13, 2025
@openjdk
Copy link

openjdk bot commented Feb 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

⚠️ @galderz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@galderz
Copy link
Contributor Author

galderz commented Feb 13, 2025

/approval

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@galderz usage: /approval [<id>] (request|cancel) [<text>]

@galderz
Copy link
Contributor Author

galderz commented Feb 13, 2025

/approval request The bug impacts Red Hat middleware engineers trying to adopt JDK's xalan API

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@galderz
8344925: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 13, 2025
@galderz
Copy link
Contributor Author

galderz commented Feb 18, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@galderz
Your change (at version 5f6d6d3) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 18, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

Going to push as commit ba481f0.
Since your change was applied there have been 13 commits pushed to the master branch:

  • d38ab94: 8349751: AIX build failure after upgrade pipewire to 1.3.81
  • a6de59e: 8348675: TrayIcon tests fail in Ubuntu 24.10 Wayland
  • e8808b7: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
  • d06d7a4: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
  • d8feb0f: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges
  • e3d6b0a: 8348600: Update PipeWire to 1.3.81
  • 2397bea: 8322983: Virtual Threads: exclude 2 tests
  • cb5f489: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
  • 754e5dd: 8349058: 'internal proprietary API' warnings make javac warnings unusable
  • 010833d: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • ... and 3 more: https://git.openjdk.org/jdk24u/compare/63a800da86a986010fe8a4777781a1b56a46200b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2025
@openjdk openjdk bot closed this Feb 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@jerboaa @galderz Pushed as commit ba481f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants