Skip to content

8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vnkozlov
Copy link

@vnkozlov vnkozlov commented Feb 21, 2025

Hi all,

This pull request contains a backport of commit 0b50e479 from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Kozlov on 13 Feb 2025 and was reviewed by Dean Long and Aleksey Shipilev.

Thanks!


Progress

  • JDK-8349753 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/87/head:pull/87
$ git checkout pull/87

Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.org/jdk24u.git pull/87/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 87

View PR using the GUI difftool:
$ git pr show -t 87

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/87.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0b50e479a060cf745a3e858d535516444fe80fd8 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@vnkozlov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

Going to push as commit a5f39c1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2025
@openjdk openjdk bot closed this Feb 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@vnkozlov Pushed as commit a5f39c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant