Skip to content

8350137: After JDK-8348975, Linux builds contain man pages for windows only tools #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Feb 24, 2025

Hi all,

This pull request contains a backport of commit 53db5764 from the openjdk/jdk repository.

The commit being backported was authored by Nizar Benalla on 20 Feb 2025 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • JDK-8350137 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350137: After JDK-8348975, Linux builds contain man pages for windows only tools (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/89/head:pull/89
$ git checkout pull/89

Update a local copy of the PR:
$ git checkout pull/89
$ git pull https://git.openjdk.org/jdk24u.git pull/89/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 89

View PR using the GUI difftool:
$ git pr show -t 89

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/89.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@nizarbenalla nizarbenalla marked this pull request as ready for review February 24, 2025 15:27
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350137: After JDK-8348975, Linux builds contain man pages for windows only tools

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • bbecbaf: 8349943: [JMH] Use jvmArgs consistently
  • a0bee88: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
  • 2d22e13: 8349150: Support precompiled headers on AIX
  • f8b84a9: 8347377: Add validation checks for ICC_Profile header fields
  • ab9a2fd: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 53db57648a09c4c380064eea11fcdb680011d741 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools Feb 24, 2025
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 24, 2025

⚠️ @nizarbenalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 24, 2025
@nizarbenalla
Copy link
Member Author

this clean backport will require a sponsor

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 26, 2025
@openjdk
Copy link

openjdk bot commented Feb 26, 2025

@nizarbenalla
Your change (at version 2c750ee) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 26, 2025

Going to push as commit ef35e66.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 114f2e3: 8348323: Corrupted timezone string in JVM crash log
  • 6fb19bb: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently
  • bbecbaf: 8349943: [JMH] Use jvmArgs consistently
  • a0bee88: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
  • 2d22e13: 8349150: Support precompiled headers on AIX
  • f8b84a9: 8347377: Add validation checks for ICC_Profile header fields
  • ab9a2fd: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2025
@openjdk openjdk bot closed this Feb 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 26, 2025
@openjdk
Copy link

openjdk bot commented Feb 26, 2025

@phohensee @nizarbenalla Pushed as commit ef35e66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the backport-nizarbenalla-53db5764-master branch February 26, 2025 17:25
@nizarbenalla
Copy link
Member Author

Thanks Paul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants