-
Notifications
You must be signed in to change notification settings - Fork 63
8350499: Minimal build fails with slowdebug builds #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350499: Minimal build fails with slowdebug builds #92
Conversation
👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into |
@theaoqi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request The backport is clean and solves corner case build issues. Risk is low. |
/integrate |
/sponsor |
Going to push as commit 1eed4ba.
Your commit was automatically rebased without conflicts. |
@phohensee @theaoqi Pushed as commit 1eed4ba. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 302bed05 from the openjdk/jdk repository.
The commit being backported was authored by Ao Qi on 24 Feb 2025 and was reviewed by Kim Barrett and David Holmes.
The backport is clean and solves corner case build issues. Risk is low.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/92/head:pull/92
$ git checkout pull/92
Update a local copy of the PR:
$ git checkout pull/92
$ git pull https://git.openjdk.org/jdk24u.git pull/92/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 92
View PR using the GUI difftool:
$ git pr show -t 92
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/92.diff
Using Webrev
Link to Webrev Comment