Skip to content

8373998: RISC-V: simple optimization of ConvHF2F#116

Closed
RealFYang wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-RealFYang-5eb87749-master
Closed

8373998: RISC-V: simple optimization of ConvHF2F#116
RealFYang wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-RealFYang-5eb87749-master

Conversation

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Dec 19, 2025

Hi all,

This pull request contains a backport of commit 5eb87749 from the openjdk/jdk repository.

The commit being backported was authored by Hamlin Li on 19 Dec 2025 and was reviewed by Fei Yang and Dingli Zhang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373998 needs maintainer approval

Issue

  • JDK-8373998: RISC-V: simple optimization of ConvHF2F (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/116/head:pull/116
$ git checkout pull/116

Update a local copy of the PR:
$ git checkout pull/116
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 116

View PR using the GUI difftool:
$ git pr show -t 116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/116.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373998: RISC-V: simple optimization of ConvHF2F

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5eb8774909bd250c7ff8cfc56506a949b547bda2 8373998: RISC-V: simple optimization of ConvHF2F Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 19, 2025
@RealFYang RealFYang marked this pull request as ready for review December 19, 2025 12:57
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

⚠️ @RealFYang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2025
@RealFYang
Copy link
Member Author

/approval request Backport to improve C2 code generation when converting incoming short value to a FP32 value.
This is a RISC-V specific change. Performed hs:tier1-hs:tier3 tests on linux-riscv64 platform with Zfh extension.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@RealFYang
8373998: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 23, 2025
@RealFYang
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

Going to push as commit bf5c6a8.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2025
@openjdk openjdk bot closed this Dec 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2025
@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@RealFYang Pushed as commit bf5c6a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant