8373630: r18_tls should not be modified on Windows AArch64#128
8373630: r18_tls should not be modified on Windows AArch64#128shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Fixes important Virtual Threads bug that affects JDK 24+. Applies cleanly. Testing passes. The patch is relatively recent, but it is also simple, and have no recorded bugtail after several weeks in mainline. Risk is low-medium: touches the core code, but in a simple manner. |
|
Push approval granted. /integrate |
|
Going to push as commit 84ee2e8.
Your commit was automatically rebased without conflicts. |
…ch64 (#19)" This reverts commit 9300fda. It was backported upstream in openjdk/jdk25u-dev#128
…ch64 (#19)" (#20) This reverts commit 9300fda. It was backported upstream in openjdk/jdk25u-dev#128
Fixes Virtual Thread bug that affects JDK 24+.
Additional testing:
tier1Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/128/head:pull/128$ git checkout pull/128Update a local copy of the PR:
$ git checkout pull/128$ git pull https://git.openjdk.org/jdk25u-dev.git pull/128/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 128View PR using the GUI difftool:
$ git pr show -t 128Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/128.diff
Using Webrev
Link to Webrev Comment