Skip to content

8373630: r18_tls should not be modified on Windows AArch64#128

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8373630-r18-tls
Closed

8373630: r18_tls should not be modified on Windows AArch64#128
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8373630-r18-tls

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jan 5, 2026

Fixes Virtual Thread bug that affects JDK 24+.

Additional testing:

  • GHA
  • macos-aarch64-server-fastdebug, tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373630 needs maintainer approval

Issue

  • JDK-8373630: r18_tls should not be modified on Windows AArch64 (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/128/head:pull/128
$ git checkout pull/128

Update a local copy of the PR:
$ git checkout pull/128
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 128

View PR using the GUI difftool:
$ git pr show -t 128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/128.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373630: r18_tls should not be modified on Windows AArch64

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a0dd66f92d7f8400b9800847e36d036315628afb 8373630: r18_tls should not be modified on Windows AArch64 Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jan 5, 2026

/approval request Fixes important Virtual Threads bug that affects JDK 24+. Applies cleanly. Testing passes. The patch is relatively recent, but it is also simple, and have no recorded bugtail after several weeks in mainline. Risk is low-medium: touches the core code, but in a simple manner.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@shipilev
8373630: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 5, 2026
@shipilev
Copy link
Member Author

shipilev commented Jan 9, 2026

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2026

Going to push as commit 84ee2e8.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2026
@openjdk openjdk bot closed this Jan 9, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2026
@openjdk
Copy link

openjdk bot commented Jan 9, 2026

@shipilev Pushed as commit 84ee2e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

swesonga added a commit to microsoft/openjdk-jdk25u that referenced this pull request Jan 21, 2026
swesonga added a commit to microsoft/openjdk-jdk25u that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants