8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing

[rm-gh-8]

Backporting JDK-8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing.

This PR fixes a test bug where getFields() is incorrectly used to discover package-private fields. Since getFields() only returns public fields, no VarHandle was actually being tested, causing a newly added assertFalse to fail.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/lang/invoke/TestVHInvokerCaching.java

Results attached:

linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8373832 needs maintainer approval

Issue

• JDK-8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/187/head:pull/187
$ git checkout pull/187

Update a local copy of the PR:
$ git checkout pull/187
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 187

View PR using the GUI difftool:
$ git pr show -t 187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/187.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 8839f6c: 8373704: Improve "SocketException: Protocol family unavailable" message
• e2b6007: 8375549: ConcurrentModificationException if jdk.crypto.disabledAlgorithms has multiple entries with known oid
• 2a57d96: 8369991: Thread blocking during JFR emergency dump must be in safepoint safe state
• ... and 8 more: https://git.openjdk.org/jdk25u-dev/compare/6c1dfb38050152b0afe18badf2c960b710ff3ce0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (88a9cdf0)

[rm-gh-8]

/approval request for backport of JDK-8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing.

This is a test fix.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8373832: The approval request has been created successfully.

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 88a9cdf) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit b6c74c1.
Since your change was applied there have been 14 commits pushed to the master branch:

• d0db33f: 8360395: sun/security/tools/keytool/i18n.java user country is current user location instead of the language
• 24cd413: 8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException
• ee0e58c: 8374644: Regression in GZIPInputStream performance after JDK-7036144
• ... and 11 more: https://git.openjdk.org/jdk25u-dev/compare/6c1dfb38050152b0afe18badf2c960b710ff3ce0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit b6c74c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.