8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"#189
8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"#189rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost". This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
/sponsor |
|
Going to push as commit a195e8a.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit a195e8a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost".
The WebSocketTest experienced an intermittent timeout failure where WebSocketBuilder::build's CompletableFuture never completed.
Root Cause (suspected): Request misdirection due to using "localhost" in the URI, which can resolve to either IPv4 (127.0.0.1) or IPv6 (::1) depending on system configuration.
Fix: Change DummyWebSocketServer::getURI to return a URI with a literal IP address instead of "localhost" to ensure consistent address resolution and prevent misdirection.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/net/httpclient/websocket
Results attached:
macos-aarch64-specific-test.log
windows-x64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/189/head:pull/189$ git checkout pull/189Update a local copy of the PR:
$ git checkout pull/189$ git pull https://git.openjdk.org/jdk25u-dev.git pull/189/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 189View PR using the GUI difftool:
$ git pr show -t 189Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/189.diff
Using Webrev
Link to Webrev Comment