Skip to content

8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException#203

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8255463-V25
Closed

8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException#203
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8255463-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Jan 29, 2026

Backporting JDK-8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException.

This PR removes the 30-second timeout from InheritedChannelTest.test() method to enable better debugging of intermittent timeout failures.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java

Results attached;

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8255463 needs maintainer approval

Issue

  • JDK-8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/203/head:pull/203
$ git checkout pull/203

Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 203

View PR using the GUI difftool:
$ git pr show -t 203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/203.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a26221299e657b64379d2d56ed3b073f12b227d1 8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException Jan 29, 2026
@openjdk
Copy link

openjdk bot commented Jan 29, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 29, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review January 29, 2026 18:25
@openjdk
Copy link

openjdk bot commented Jan 29, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Jan 30, 2026

/approval request for backport of JDK-8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Jan 30, 2026

@rm-gh-8
8255463: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 30, 2026
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 2, 2026

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 2, 2026
@openjdk
Copy link

openjdk bot commented Feb 2, 2026

@rm-gh-8
Your change (at version 96a498e) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Feb 2, 2026

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 2, 2026

Going to push as commit 424b67e.
Since your change was applied there have been 31 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@shipilev
Copy link
Member

shipilev commented Feb 2, 2026

This one has a follow-up bug report: JDK-8375345 -- does this PR regress the testing?

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2026
@openjdk openjdk bot closed this Feb 2, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 2, 2026
@openjdk
Copy link

openjdk bot commented Feb 2, 2026

@shipilev @rm-gh-8 Pushed as commit 424b67e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants