8365065: cancelled ForkJoinPool tasks no longer throw CancellationException #3
+70
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8365065: Cancelled ForkJoinPool tasks no longer throw CancellationException. Fixes the exception propagation and tests. Based on the original bug it is a regression and it last worked in version 17.0.16. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/util/concurrent
Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
Progress
Warning
8365065: cancelled ForkJoinPool tasks no longer throw CancellationExceptionIssue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/3/head:pull/3$ git checkout pull/3Update a local copy of the PR:
$ git checkout pull/3$ git pull https://git.openjdk.org/jdk25u-dev.git pull/3/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3View PR using the GUI difftool:
$ git pr show -t 3Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/3.diff
Using Webrev
Link to Webrev Comment