Skip to content

8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip#66

Closed
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-ef7532e7-master
Closed

8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip#66
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-ef7532e7-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 5, 2025

Hi all,

This pull request contains a backport of commit ef7532e7 from the openjdk/jdk repository.

The commit being backported was authored by Mikhail Yankelevich on 4 Dec 2025 and was reviewed by Rajan Halade.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367994 needs maintainer approval

Issue

  • JDK-8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/66/head:pull/66
$ git checkout pull/66

Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/66/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 66

View PR using the GUI difftool:
$ git pr show -t 66

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/66.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ef7532e7e625628d6181c65116804ebb65f18061 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2026

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test throw SkippedException when they should skip. Change has been verified locally on linux-x64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Jan 4, 2026

@sendaoYan
8367994: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 4, 2026
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2026

Going to push as commit 56f04ce.
Since your change was applied there have been 170 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2026
@openjdk openjdk bot closed this Feb 1, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2026
@openjdk
Copy link

openjdk bot commented Feb 1, 2026

@sendaoYan Pushed as commit 56f04ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant