8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#89
8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#89sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 243 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Change has been verified locally on linux-x64. This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Verify command: |
|
/touch |
|
@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/approval request Clean backport to fix bug which try to make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Change has been verified locally on linux-x64. Test-fix only, no risk. |
|
@sendaoYan |
|
Please bring this to JDK 26u before older versions can be considered. |
|
/approval request Clean backport to fix bug which try to make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Change has been verified locally on linux-x64. Test-fix only, no risk. |
|
@sendaoYan |
|
/approve yes |
|
@jerboaa |
|
Thanks for the approved /integrate |
|
Going to push as commit f083faf.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit f083faf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 34f24131 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 15 Dec 2025 and was reviewed by Leonid Mesnik and David Holmes.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/89/head:pull/89$ git checkout pull/89Update a local copy of the PR:
$ git checkout pull/89$ git pull https://git.openjdk.org/jdk25u-dev.git pull/89/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 89View PR using the GUI difftool:
$ git pr show -t 89Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/89.diff
Using Webrev
Link to Webrev Comment