-
Notifications
You must be signed in to change notification settings - Fork 110
8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back truptipatil-13! A progress list of the required criteria for merging this PR into |
|
@truptipatil-13 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8335986 request Clean backport, Modified bug4449413.java to fix the test for Windows. |
|
@truptipatil-13 |
|
/integrate |
|
@truptipatil-13 |
|
/sponsor |
|
Going to push as commit 885510d.
Your commit was automatically rebased without conflicts. |
|
@phohensee @truptipatil-13 Pushed as commit 885510d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
[JTREG Testing] (1 manual test )
runner starting test: javax/swing/JCheckBox/4449413/bug4449413.java
runner finished test: javax/swing/JCheckBox/4449413/bug4449413.java
Passed. Execution successful
Test results: passed: 1
Conflicts
No conflicts. Clean backport.
Are higher backports completed(25u,21u,17u,11u,8u etc) ?
Applicable to 25u via this MR and the others are being worked upon.
Does it contain multiple changesets ?
No
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/101/head:pull/101$ git checkout pull/101Update a local copy of the PR:
$ git checkout pull/101$ git pull https://git.openjdk.org/jdk25u.git pull/101/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 101View PR using the GUI difftool:
$ git pr show -t 101Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/101.diff
Using Webrev
Link to Webrev Comment