Skip to content

Conversation

@truptipatil-13
Copy link
Contributor

@truptipatil-13 truptipatil-13 commented Aug 19, 2025

  • Testing
    [JTREG Testing] (1 manual test )

runner starting test: javax/swing/JCheckBox/4449413/bug4449413.java
runner finished test: javax/swing/JCheckBox/4449413/bug4449413.java
Passed. Execution successful
Test results: passed: 1

  • Conflicts
    No conflicts. Clean backport.

  • Are higher backports completed(25u,21u,17u,11u,8u etc) ?
    Applicable to 25u via this MR and the others are being worked upon.

  • Does it contain multiple changesets ?
    No


Progress

  • Change must not contain extraneous whitespace
  • JDK-8335986 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/101/head:pull/101
$ git checkout pull/101

Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.org/jdk25u.git pull/101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 101

View PR using the GUI difftool:
$ git pr show -t 101

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/101.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

👋 Welcome back truptipatil-13! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@truptipatil-13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e0fd1f9: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
  • 2527333: 8356897: Update NSS library to 3.111
  • 8f9e740: 8357382: runtime/cds/appcds/aotClassLinking/BulkLoaderTest.java#aot fails with Xcomp and C1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c51bed739d97167ae768e204dd8666d078d2e607 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

⚠️ @truptipatil-13 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2025

Webrevs

@truptipatil-13
Copy link
Contributor Author

/approval JDK-8335986 request Clean backport, Modified bug4449413.java to fix the test for Windows.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@truptipatil-13
JDK-8335986: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 19, 2025
@truptipatil-13
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@truptipatil-13
Your change (at version e8c13fa) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

Going to push as commit 885510d.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2025
@openjdk openjdk bot closed this Aug 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@phohensee @truptipatil-13 Pushed as commit 885510d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants