Skip to content

Conversation

@shyamkishororacle
Copy link
Contributor

@shyamkishororacle shyamkishororacle commented Aug 19, 2025

…eouts


Progress

  • Change must not contain extraneous whitespace
  • JDK-8362602 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.org/jdk25u.git pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/103.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

👋 Welcome back shyamkishororacle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@shyamkishororacle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f8c8bcf4fd31509fdb40d32e8e16ba4fba1f987d 8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

⚠️ @shyamkishororacle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2025

Webrevs

@shyamkishororacle
Copy link
Contributor Author

/approval

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@shyamkishororacle usage: /approval [<id>] (request|cancel) [<text>]

@shyamkishororacle
Copy link
Contributor Author

/approval 8362602 request Clean backport. Add test.timeout.factor to CompileFactory to avoid test timeouts

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@shyamkishororacle
8362602: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 20, 2025
@TheRealMDoerr
Copy link
Contributor

Thanks for backporting! This one was on our list, too.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

⚠️ @shyamkishororacle the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backpot-8362602
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 20, 2025
@shyamkishororacle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@shyamkishororacle
Your change (at version 2b5d808) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

Going to push as commit 4b37d97.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2025
@openjdk openjdk bot closed this Aug 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@shipilev @shyamkishororacle Pushed as commit 4b37d97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants