Skip to content

Conversation

@hari-kummari
Copy link

@hari-kummari hari-kummari commented Aug 20, 2025

Tested local changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8360981 needs maintainer approval

Issue

  • JDK-8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.org/jdk25u.git pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/109.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back hkummari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@hari-kummari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 76a5c2d: 8361599: [PPC64] enable missing tests via jtreg requires
  • e0fd1f9: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
  • 2527333: 8356897: Update NSS library to 3.111

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title backport 3263361a28c7e8c02734cb94bc9576e9f3ba5b50 8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 20, 2025
@openjdk
Copy link

openjdk bot commented Aug 20, 2025

⚠️ @hari-kummari This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

@hari-kummari
Copy link
Author

/approval request

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@hari-kummari
8360981: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 20, 2025
@hari-kummari
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@hari-kummari
Your change (at version 769ae1e) is now ready to be sponsored by a Committer.

@hari-kummari
Copy link
Author

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@hari-kummari Only Committers are allowed to sponsor changes.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

Going to push as commit 67faaf1.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2025
@openjdk openjdk bot closed this Aug 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 21, 2025
@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@phohensee @hari-kummari Pushed as commit 67faaf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants