Skip to content

8349188: LineBorder does not scale correctly#134

Closed
aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-aivanov-jdk-24117c6e-master
Closed

8349188: LineBorder does not scale correctly#134
aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-aivanov-jdk-24117c6e-master

Conversation

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Aug 25, 2025

This pull request contains a backport of commit 24117c6e from the openjdk/jdk repository.

The commit being backported was authored by Rajat Mahajan on 3 Jul 2025 and was reviewed by Alexey Ivanov and Sergey Bylokhov.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8349188 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8349188: LineBorder does not scale correctly (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/jdk25u.git pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/134.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349188: LineBorder does not scale correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 24117c6e9aa862bad839e93eff70810a75605ac5 8349188: LineBorder does not scale correctly Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2025

Webrevs

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

Going to push as commit 78972ee.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2025
@openjdk openjdk bot closed this Aug 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2025
@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@aivanov-jdk Pushed as commit 78972ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the backport-aivanov-jdk-24117c6e-master branch August 26, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant