Skip to content

Conversation

@vamsi-parasa
Copy link

@vamsi-parasa vamsi-parasa commented Jul 9, 2025

Hello Everyone,

This pull request contains a backport of commit 1c560727 from the openjdk/jdk repository.

This is a P3 bug which fixes issue with shenandoah tests when APX is used.

The commit being backported was authored by Srinivas Vamsi Parasa on 4 Jul 2025 and was reviewed by Sandhya Viswanathan, Jatin Bhateja and Emanuel Peter.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8360775 needs maintainer approval

Issue

  • JDK-8360775: Fix Shenandoah GC test failures when APX is enabled (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk25u.git pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/14.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back sparasa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@vamsi-parasa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360775: Fix Shenandoah GC test failures when APX is enabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1c560727b850593561982ccc3ed37b0e98b3bbee 8360775: Fix Shenandoah GC test failures when APX is enabled Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

⚠️ @vamsi-parasa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@vamsi-parasa usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Jul 9, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@vamsi-parasa This issue is not associated with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@vamsi-parasa usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 10, 2025
@vamsi-parasa
Copy link
Author

/approval 8360775 request backport

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@vamsi-parasa
8360775: The approval request has been created successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 11, 2025
@vamsi-parasa
Copy link
Author

Created this PR by mistake. The original intention was to backport to jdk25 (not jdk25u). Sorry for the inconvenience caused!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant