8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel#180
Conversation
|
👋 Welcome back TheSarveshJain! A progress list of the required criteria for merging this PR into |
|
@TheSarveshJain This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8346753 request Clean backport, Improvement of manual test 'javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java' in 25u. |
|
@TheSarveshJain |
|
/integrate |
|
@TheSarveshJain |
|
/sponsor |
|
Going to push as commit d09a3b8.
Your commit was automatically rebased without conflicts. |
|
@phohensee @TheSarveshJain Pushed as commit d09a3b8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8346753
Test fixed in 26, backporting to 25.
Testing Done: Manual test executed with jtreg on latest jdk-25.
runner starting test: javax/swing/JMenuItem/RightLeftOrientation.java#metal
runner finished test: javax/swing/JMenuItem/RightLeftOrientation.java#metal
Passed. Execution successful
runner starting test: javax/swing/JMenuItem/RightLeftOrientation.java#motif
runner finished test: javax/swing/JMenuItem/RightLeftOrientation.java#motif
Passed. Execution successful
runner starting test: javax/swing/JMenuItem/RightLeftOrientation.java#windows
runner finished test: javax/swing/JMenuItem/RightLeftOrientation.java#windows
Passed. Execution successful
Test results: passed: 3
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/180/head:pull/180$ git checkout pull/180Update a local copy of the PR:
$ git checkout pull/180$ git pull https://git.openjdk.org/jdk25u.git pull/180/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 180View PR using the GUI difftool:
$ git pr show -t 180Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/180.diff
Using Webrev
Link to Webrev Comment