Skip to content

Conversation

@disha-morye
Copy link
Contributor

@disha-morye disha-morye commented Sep 12, 2025

Hi all,

This pull request contains a backport of commit 9f697c8 from the openjdk/jdk repository.

The commit being backported was authored by Disha Morye on 5 Sep 2025

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366764 needs maintainer approval

Issue

  • JDK-8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/187/head:pull/187
$ git checkout pull/187

Update a local copy of the PR:
$ git checkout pull/187
$ git pull https://git.openjdk.org/jdk25u.git pull/187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 187

View PR using the GUI difftool:
$ git pr show -t 187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/187.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back disha-morye! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@disha-morye This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 195 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2025
@disha-morye
Copy link
Contributor Author

/label client

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@disha-morye
The label client is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@disha-morye disha-morye changed the title 8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java Backport 9f697c8b1ced41c256bd33f52bdcb2cede2adbf9 Sep 12, 2025
@openjdk openjdk bot changed the title Backport 9f697c8b1ced41c256bd33f52bdcb2cede2adbf9 8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

⚠️ @disha-morye This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@disha-morye
Copy link
Contributor Author

/approval 8366764 request to backport to jdk25u. Deproblem listed ScrollPositionTest.java since it is passing now

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@disha-morye
8366764: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

⚠️ @disha-morye the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8366764
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 12, 2025
@disha-morye
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 16, 2025
@openjdk
Copy link

openjdk bot commented Sep 16, 2025

@disha-morye
Your change (at version 79c924a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 16, 2025

Going to push as commit 211e943.
Since your change was applied there have been 199 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2025
@openjdk openjdk bot closed this Sep 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 16, 2025
@openjdk
Copy link

openjdk bot commented Sep 16, 2025

@shipilev @disha-morye Pushed as commit 211e943.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants